Fix scipy errors fid#3793
Closed
aaishwarymishra wants to merge 1 commit into
Closed
Conversation
aaishwarymishra
force-pushed
the
fix-scipy-errors-fid
branch
from
f6a45d7 to
7f5f7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins scipy<=1.17.0 in requirements-dev.txt to fix failing unit tests caused by scipy.linalg.sqrtm removing the disp
parameter in
SciPy 1.18.0 .
Problem
In SciPy 1.16.0 , the disp parameter in scipy.linalg.sqrtm was deprecated, and it was completely removed in SciPy 1.18.0 .
However, the pytorch-fid library (which we use in test_fid.py to validate our FID metric implementation) still passes
disp=False to scipy.linalg.sqrtm .
When running tests with SciPy 1.18.0 or newer, this mismatch results in a TypeError: sqrtm() got an unexpected keyword
argument 'disp' , causing our test suite (specifically FID metric unit tests) to fail.
Solution
Since pytorch-fid is a third-party dependency used primarily for validation in our dev/test environment, we restrict the scipy dependency in requirements-dev.txt to <=1.17.0 . This ensures that the test suite continues to run successfully on environments using the pinned SciPy version.