build: Update mmcore to 12.0.0 - #78
Merged
Merged
Conversation
MMEventCallback callbacks become always asynchronous. Tests for callbacks now use threading.Event to wait (with a timeout) for the async call. (Assisted by Claude Code; any errors are mine.)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 2 2
Lines 1231 1231
Branches 958 958
=======================================
Hits 938 938
Misses 92 92
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thanks @marktsuchida ... I cleaned up the pattern a little bit with a context manager in a12fb7a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MMEventCallback callbacks become always asynchronous.
Tests for callbacks now use threading.Event to wait (with a timeout) for the async call.
Cf. micro-manager/pymmcore#169.