ci: add step to check wheel contents before uploading artifacts - #66
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 2 2
Lines 1218 1218
Branches 947 947
=======================================
Hits 928 928
Misses 92 92
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored stub generation in
meson.build: The stub generation step now usescustom_targetwith explicit input/output, installs the stub directly to the correct site-packages directory, and adds a development-time copy to the source tree for Pyright compatibility. Pure-Python package files are now installed usingpy.install_sources, replacing previous manual install steps.Improved Windows DLL discovery for stub generation: Added
_windows_dll_dirscontext manager inscripts/build_stubs.pyto ensure dependent DLLs are discoverable when importing the extension on Windows, preventing import errors during stub generation. [1] [2]Added wheel content validation to CI: The
check-wheel-contentstool is now run in the GitHub Actions workflow to verify wheel correctness after building.Integrated wheel content checks in local test workflow: The
pyproject.tomlnow requirescheck-wheel-contentsfor tests and runs it beforepytestto ensure wheels are valid before running tests.Added configuration for
check-wheel-contents: Thepyproject.tomlincludes a[tool.check-wheel-contents]section specifying the package layout and ignored warnings for more robust wheel validation.