Skip to content

ci: add step to check wheel contents before uploading artifacts - #66

Merged
tlambert03 merged 5 commits into
pymmcore-plus:mainfrom
tlambert03:fix-wheel
Sep 4, 2025
Merged

ci: add step to check wheel contents before uploading artifacts#66
tlambert03 merged 5 commits into
pymmcore-plus:mainfrom
tlambert03:fix-wheel

Conversation

@tlambert03

@tlambert03 tlambert03 commented Sep 2, 2025

Copy link
Copy Markdown
Member
  • Refactored stub generation in meson.build: The stub generation step now uses custom_target with explicit input/output, installs the stub directly to the correct site-packages directory, and adds a development-time copy to the source tree for Pyright compatibility. Pure-Python package files are now installed using py.install_sources, replacing previous manual install steps.

  • Improved Windows DLL discovery for stub generation: Added _windows_dll_dirs context manager in scripts/build_stubs.py to ensure dependent DLLs are discoverable when importing the extension on Windows, preventing import errors during stub generation. [1] [2]

  • Added wheel content validation to CI: The check-wheel-contents tool is now run in the GitHub Actions workflow to verify wheel correctness after building.

  • Integrated wheel content checks in local test workflow: The pyproject.toml now requires check-wheel-contents for tests and runs it before pytest to ensure wheels are valid before running tests.

  • Added configuration for check-wheel-contents: The pyproject.toml includes a [tool.check-wheel-contents] section specifying the package layout and ignored warnings for more robust wheel validation.

@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.19%. Comparing base (ad263c7) to head (cc41ef6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files           2        2           
  Lines        1218     1218           
  Branches      947      947           
=======================================
  Hits          928      928           
  Misses         92       92           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
tlambert03 merged commit 138b0a3 into pymmcore-plus:main Sep 4, 2025
19 checks passed
@tlambert03
tlambert03 deleted the fix-wheel branch September 4, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant