refactor: remove mmCoreAndDevices source code , use meson wraps - #65
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (61.11%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage ? 76.19%
=======================================
Files ? 2
Lines ? 1218
Branches ? 947
=======================================
Hits ? 928
Misses ? 92
Partials ? 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tlambert03
changed the title
tlambert03
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marktsuchida if you have a moment to glance at the changes here, that would be great.
This comes closer to the
pymmcorebuild pipeline. Uses the new mirrors, stops building test-devices internally and just usesmm-test-adapters. I suppose the top level meson.build (https://github.com/pymmcore-plus/pymmcore-nano/pull/65/files#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4) would be the main thing to review. (we could perhaps make it even more like pymmcore...)