Docs revamp#692
Closed
ricardoV94 wants to merge 3 commits into
Closed
Conversation
Redesign marginalization around two concepts: 1. marginalize(model) creates MarginalSubgraph markers at build time, resolved to typed MarginalRVs (e.g. MarginalFiniteDiscreteRV) via an EquilibriumDB of logprob rewrites. 2. conditional(model) replaces marginalized variables with their conditional posterior distributions as free RVs, returning a standard PyMC model that works with compile_logp and sample_posterior_predictive. recover_marginals now uses conditional() + sample_posterior_predictive internally. Other changes: - Remove the deprecated MarginalModel class - Split marginal_model.py into model.py, distributions/, rewrites.py - Support sequential marginalize via unwrap_inner_marginal_rv rewrite
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
===========================================
+ Coverage 51.60% 91.04% +39.44%
===========================================
Files 73 88 +15
Lines 8003 8301 +298
===========================================
+ Hits 4130 7558 +3428
+ Misses 3873 743 -3130
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes commits from #688