Add deserialize module#489
Merged
Merged
Conversation
williambdean
changed the title
Contributor
|
Ok #470 is merged so I think after this is rebased and passes CI, we can merge it too |
Collaborator
Author
|
Seem like unrelated fails... |
Contributor
|
Try rebasing from main and it should work now
…On Tue, 3 Jun 2025, 08:05 Will Dean, ***@***.***> wrote:
*williambdean* left a comment (pymc-devs/pymc-extras#489)
<#489 (comment)>
Seem like unrelated fails...
—
Reply to this email directly, view it on GitHub
<#489 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUMNMEIAADA2W7ZLEI33BU3KHAVCNFSM6AAAAAB6FTNIHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZTGYYTCNBRHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
zaxtax
approved these changes
Jun 3, 2025
zaxtax
left a comment
zaxtax
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Once this passes CI we can merge it in
Collaborator
Author
|
Thanks @zaxtax for the review! |
zaxtax
reviewed
Jun 3, 2025
Contributor
|
Yep and then let's get this merged 😃
…On Tue, 3 Jun 2025, 18:09 Will Dean, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pymc_extras/prior.py
<#489 (comment)>
:
> + dist.to_dict()
+ # {"dist": "Normal", "kwargs": {"mu": 0, "sigma": 1}}
+
+ Convert a hierarchical prior to the dictionary format.
+
+ .. code-block:: python
+
+ dist = Prior(
+ "Normal",
+ mu=Prior("Normal"),
+ sigma=Prior("HalfNormal"),
+ dims="channel",
+ )
+
+ dist.to_dict()
+ # {
I have removed the commented code. There is also one above. Do you want
that removed as well
—
Reply to this email directly, view it on GitHub
<#489 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUKYJE43UPPOSTHFRKL3BXCBRAVCNFSM6AAAAAB6FTNIHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOJTGIYTQMRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
Author
|
Done! |
andreacate
pushed a commit
to andreacate/pymc-extras
that referenced
this pull request
Jul 22, 2025
andreacate
pushed a commit
to andreacate/pymc-extras
that referenced
this pull request
Jul 25, 2025
velochy
pushed a commit
to velochy/pymc-extras
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will rebase one #470 is merged