ENH: allow keeping original PDF header in non-incremental clone mode#3918
Open
pctablet505 wants to merge 1 commit into
Open
ENH: allow keeping original PDF header in non-incremental clone mode#3918pctablet505 wants to merge 1 commit into
pctablet505 wants to merge 1 commit into
Conversation
Add a keep_initial_header parameter to PdfWriter.__init__ that preserves the source document's header when using clone_from. Fixes py-pdf#3386
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3918 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 57 57
Lines 10738 10740 +2
Branches 2006 2007 +1
=======================================
+ Hits 10509 10511 +2
Misses 127 127
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pctablet505
marked this pull request as ready for review
July 17, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3386
Adds a keep_initial_header parameter to PdfWriter.init so that clone_from can preserve the source document's PDF header in non-incremental mode. When the parameter is not set, the existing PDF 1.3 default is retained for backwards compatibility.
This PR was prepared with AI assistance and reviewed by the contributor.