ROB: guard text fields without /T in get_form_text_fields#3903
Open
metsw24-max wants to merge 1 commit into
Open
ROB: guard text fields without /T in get_form_text_fields#3903metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 57 57
Lines 10738 10738
Branches 2006 2006
=======================================
Hits 10509 10509
Misses 127 127
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
any update? |
Collaborator
|
See #3900. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyError on text fields without a partial name
A
/Txfield that carries only a mapping name (/TM) and no partial name (/T) is still kept by_build_field, soget_form_text_fields()then trips over the direct/Tlookup and raisesKeyErroron the public read path. The fallback reuses the qualified name already used by thefull_qualified_namevariant, so such a field is returned rather than aborting the whole call. Added a regression test building that field shape.