docs: Updating ApiConfig to reference .api_id instead of .id#2963
Draft
rshade wants to merge 1 commit into
Draft
docs: Updating ApiConfig to reference .api_id instead of .id#2963rshade wants to merge 1 commit into
rshade wants to merge 1 commit into
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2963 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 3 3
Lines 166 166
======================================
Misses 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| var apiConfigApiId = tfbridge.DocsEdit{ | ||
| Path: "*api_gateway_api_config.html.markdown", | ||
| Edit: func(_ string, content []byte) ([]byte, error) { | ||
| content = effectiveLabelsRegexp.ReplaceAllLiteral(content, []byte(apiConfigApiIdStr+" **Note: use apiId if calling a resource**")) |
Contributor
There was a problem hiding this comment.
I think you want apiConfigApiIdRegexp here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.