fix: add patch for aws_rds_cluster storage_type replacement bug - #6553
Open
pierskarsenbarg wants to merge 4 commits into
Open
fix: add patch for aws_rds_cluster storage_type replacement bug#6553pierskarsenbarg wants to merge 4 commits into
pierskarsenbarg wants to merge 4 commits into
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6553 +/- ##
=======================================
Coverage 15.83% 15.83%
=======================================
Files 376 376
Lines 91928 91906 -22
=======================================
Hits 14555 14555
+ Misses 77352 77330 -22
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I linked the wrong issue in the PR text - this has been fixed now |
corymhall
requested changes
Jul 21, 2026
corymhall
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this! Before merging we just need to add some tests.
- Run the upstream acceptance test in our CI. Add the
TestAccRdsCluster_storageTypeUpdateNonAurorato theaws-upstream-tests.yml
matrix:
service:
- sqs
- ec2
+ - rds
- docdb
- redshiftserverless
- cognitoidp
include:
- service: sqs
tests: TestAccSQSQueue
- service: ec2
tests: TestAccEC2KeyPair_publicKey
+ - service: rds
+ tests: TestAccRDSCluster_storageTypeUpdateNonAurora
- service: docdb
tests: TestAccDocDBCluster_basic- Similar to the upstream test, we need a Pulumi-side examples test.
Ports hashicorp/terraform-provider-aws#48545, which removes an incorrect customdiff.ForceNewIf guard that forced replacement when storage_type changed on non-Aurora multi-AZ RDS clusters, even though the AWS ModifyDBCluster API supports in-place changes.
pierskarsenbarg
force-pushed
the
piers/upstream-rds-cluster-storage-type-patch
branch
from
July 23, 2026 14:14
890aff6 to
1a21901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patches/0028-...patch)customdiff.ForceNewIfguard onstorage_typefor non-Aurora RDS clusters that forced resource replacement even though the AWSModifyDBClusterAPI supports in-place changesstorage_typehas no staticForceNewin the TF schema, so the bridge never derived areplaceOnChangesfrom this behaviorTest plan
./scripts/upstream.sh check_inapplied all 28 patches cleanly with no conflictsgo build ./internal/service/rds/...succeeds against the patched upstream checkoutFixes: #6554