Skip to content

fix: add patch for aws_rds_cluster storage_type replacement bug - #6553

Open
pierskarsenbarg wants to merge 4 commits into
masterfrom
piers/upstream-rds-cluster-storage-type-patch
Open

fix: add patch for aws_rds_cluster storage_type replacement bug#6553
pierskarsenbarg wants to merge 4 commits into
masterfrom
piers/upstream-rds-cluster-storage-type-patch

Conversation

@pierskarsenbarg

@pierskarsenbarg pierskarsenbarg commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

  • ./scripts/upstream.sh check_in applied all 28 patches cleanly with no conflicts
  • go build ./internal/service/rds/... succeeds against the patched upstream checkout

Fixes: #6554

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.83%. Comparing base (db5955f) to head (3cd9d84).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6553   +/-   ##
=======================================
  Coverage   15.83%   15.83%           
=======================================
  Files         376      376           
  Lines       91928    91906   -22     
=======================================
  Hits        14555    14555           
+ Misses      77352    77330   -22     
  Partials       21       21           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierskarsenbarg

Copy link
Copy Markdown
Member Author

I linked the wrong issue in the PR text - this has been fixed now

@corymhall corymhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Before merging we just need to add some tests.

  1. Run the upstream acceptance test in our CI. Add the TestAccRdsCluster_storageTypeUpdateNonAurora to the aws-upstream-tests.yml
          matrix:
            service:
              - sqs
              - ec2
   +          - rds
              - docdb
              - redshiftserverless
              - cognitoidp
            include:
              - service: sqs
                tests: TestAccSQSQueue
              - service: ec2
                tests: TestAccEC2KeyPair_publicKey
   +          - service: rds
   +            tests: TestAccRDSCluster_storageTypeUpdateNonAurora
              - service: docdb
                tests: TestAccDocDBCluster_basic
  1. Similar to the upstream test, we need a Pulumi-side examples test.

Ports hashicorp/terraform-provider-aws#48545, which removes an incorrect
customdiff.ForceNewIf guard that forced replacement when storage_type
changed on non-Aurora multi-AZ RDS clusters, even though the AWS
ModifyDBCluster API supports in-place changes.
@pierskarsenbarg
pierskarsenbarg force-pushed the piers/upstream-rds-cluster-storage-type-patch branch from 890aff6 to 1a21901 Compare July 23, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws.rds.Cluster: changing storageType forces replacement on non-Aurora multi-region clusters

2 participants