Skip to content

[prometheus-modbus-exporter] fix config-reloader-sidecar deployment #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefan-kolev wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −3
Open

[prometheus-modbus-exporter] fix config-reloader-sidecar deployment #6875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-modbus-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords:

type: application

version: 0.1.4
version: 0.1.5
appVersion: "0.4.1"

maintainers:
Expand Down
9 changes: 7 additions & 2 deletions charts/prometheus-modbus-exporter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,14 @@ spec:
volumeMounts:
- name: configfile
mountPath: /etc/modbus_exporter/
{{ if .Values.configReloaderSidecar.enable }}
{{- if .Values.configReloaderSidecar.enabled }}
- name: {{ include "prometheus-modbus-exporter.fullname" . }}-config-reloader-sidecar
image: "{{ .Values.configReloaderSidecar.image.registry }}/{{ .Values.configReloaderSidecar.image.repository }}:{{ .Values.configReloaderSidecar.image.tag }}"
imagePullPolicy: {{ .Values.configReloaderSidecar.image.pullPolicy }}
{{- with .Values.configReloaderSidecar.securityContext }}
securityContext:
{{- toYaml . | nindent 12 }}
{{- end }}
env:
- name: CONFIG_DIR
value: /etc/modbus_exporter/
Expand All @@ -65,7 +70,7 @@ spec:
volumeMounts:
- name: configfile
mountPath: /etc/modbus_exporter/
{{- end -}}
{{- end }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
9 changes: 9 additions & 0 deletions charts/prometheus-modbus-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ configReloaderSidecar:
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: "20230519_90573b0"
# The config-reloader-sidecar image runs as root in order to send signals
# to the modbus_exporter process via the shared PID namespace. When the
# pod-level podSecurityContext sets runAsNonRoot: true (the default), the
# sidecar must declare a container-level securityContext that overrides it,
# otherwise kubelet refuses to start the container with
# "container has runAsNonRoot and image will run as root".
securityContext:
runAsNonRoot: false
runAsUser: 0

imagePullSecrets: []
nameOverride: ""
Expand Down