[prometheus-statsd-exporter] add priorityClassName#6856
Open
craig5 wants to merge 3 commits into
Open
Conversation
Add "priorityClassName" to value.yaml and the correspoding location in templates/deployment.yaml. Tested locally using a "wrapper chart". (I.e. a local chart that has this chart as a dependency.) The manifest is generated and deployed as expected. Signed-off-by: Craig Sebenik <csebenik@aurora.tech>
Author
|
@scDisorder I think I have completed all of the required items. |
Author
|
@scDisorder is there anything I can do to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "priorityClassName" to values.yaml and the corresponding location in templates/deployment.yaml.
Tested locally using a "wrapper chart".
(I.e. a local chart that has this chart as a dependency. But, had to manually copy the changes into the untar'd files in
charts/....)The manifest is generated and deployed as expected.
@scDisorder
What this PR does / why we need it
Our statsd exported has been preempted several times the past few weeks.
This causes some "data loss" since the statsd exporter is down while a new node is automatically created.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])