Skip to content

[prometheus-pushgateway] Fix the image registry and repository default values#6798

Open
ndebuhr wants to merge 1 commit into
prometheus-community:mainfrom
ndebuhr:prometheus-pushgateway-registry-fix
Open

[prometheus-pushgateway] Fix the image registry and repository default values#6798
ndebuhr wants to merge 1 commit into
prometheus-community:mainfrom
ndebuhr:prometheus-pushgateway-registry-fix

Conversation

@ndebuhr

@ndebuhr ndebuhr commented Mar 31, 2026

Copy link
Copy Markdown

Fix the image registry and repository values structuring in prometheus-pushgateway to match intuition and all the other charts in this repo.

What this PR does / why we need it

Which issue this PR fixes

Special notes for your reviewer

The registry being bundled into the repository value in the default Helm values is incorrect, and while not strictly a functional bug, it's an unintuitive and out-of-repo-conventions approach. Additionally, the _helper for the registry handling assumes the correct values structuring, so this seems like an initial PR oversight/error rather than a design choice.

Submitting this PR to clean this up. This is not a breaking change if folks are using the default values or the global overrides. It is breaking change if folks are using explicit image (but not global) repository or registry values.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

…gateway to match intuition and the other charts

Signed-off-by: Neal DeBuhr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant