[prometheus-pushgateway] Fix the image registry and repository default values#6798
Open
ndebuhr wants to merge 1 commit into
Open
[prometheus-pushgateway] Fix the image registry and repository default values#6798ndebuhr wants to merge 1 commit into
ndebuhr wants to merge 1 commit into
Conversation
…gateway to match intuition and the other charts Signed-off-by: Neal DeBuhr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the image registry and repository values structuring in prometheus-pushgateway to match intuition and all the other charts in this repo.
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
The registry being bundled into the repository value in the default Helm values is incorrect, and while not strictly a functional bug, it's an unintuitive and out-of-repo-conventions approach. Additionally, the _helper for the registry handling assumes the correct values structuring, so this seems like an initial PR oversight/error rather than a design choice.
Submitting this PR to clean this up. This is not a breaking change if folks are using the default values or the global overrides. It is breaking change if folks are using explicit image (but not global) repository or registry values.
Checklist
[prometheus-couchdb-exporter])