[kube-state-metrics] fix: do not render *Probe.httpGet.httpHeaders when array is empty#6783
Open
MadJlzz wants to merge 1 commit into
Open
Conversation
33fb8c9 to
bd343c6
Compare
…n array is empty Signed-off-by: Julien Klaer <j.klaer@tadaweb.com>
bd343c6 to
317a7ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR is fixing invalid YAML rendering when any probes
httpHeadersare unset. It's not mandatory because YAML spec treats undefined values as null but some linters flag those as "errors".Which issue this PR fixes
I can open an issue for traceability, I just decided not to do it - please tell me if you want me to.
Special notes for your reviewer
Before:
After:
Checklist
[prometheus-couchdb-exporter])