[kube-state-metrics] fix fullname duplication with nameOverride#6720
Open
firasmosbehi wants to merge 1 commit into
Open
[kube-state-metrics] fix fullname duplication with nameOverride#6720firasmosbehi wants to merge 1 commit into
firasmosbehi wants to merge 1 commit into
Conversation
Signed-off-by: Firas Mosbehi <firas.mosbehi@insat.ucar.tn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes fullname generation for
kube-state-metricswhennameOverridealready includes the release name, addressing #6510.Problem
With
Release.Name=ksm-non-podsandnameOverride=ksm-non-pods-foo, rendered object names become double-prefixed (ksm-non-pods-ksm-non-pods-foo).Root cause
The fullname helper only handled the case where release name contains chart/name. It did not handle the inverse case where
nameOverridealready contains release name.Fix
Updated
kube-state-metrics.fullnamehelper logic to add an inverse containment branch:nameOverridecontains release name, usenameOverrideas fullnameAlso bumped chart version from
7.2.0to7.2.1.Validation
helm lint charts/kube-state-metricshelm template ksm-non-pods charts/kube-state-metrics --set nameOverride=ksm-non-pods-fooksm-non-pods-fooand noksm-non-pods-ksm-non-pods-foonames are produced.Compatibility
Existing default naming behavior is preserved unless
nameOverridealready embeds the release name.