Skip to content

[prometheus-node-exporter] make kube-rbac-proxy listen host configurable #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firasmosbehi wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

[prometheus-node-exporter] make kube-rbac-proxy listen host configurable #6716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-node-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ keywords:
- prometheus
- exporter
type: application
version: 4.52.0
version: 4.52.1

@zeritti zeritti Mar 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 4.52.1
version: 4.53.0

# renovate: github=prometheus/node_exporter
appVersion: 1.10.2
home: https://github.com/prometheus/node_exporter/
Expand Down
2 changes: 1 addition & 1 deletion charts/prometheus-node-exporter/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ spec:
{{- if .Values.kubeRBACProxy.extraArgs }}
{{- .Values.kubeRBACProxy.extraArgs | toYaml | nindent 12 }}
{{- end }}
- --secure-listen-address=:{{ .Values.service.port}}
- --secure-listen-address={{ .Values.kubeRBACProxy.listenHost }}{{ .Values.service.port}}

@zeritti zeritti Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --secure-listen-address={{ .Values.kubeRBACProxy.listenHost }}{{ .Values.service.port}}
- --secure-listen-address={{ printf "%s:%d" .Values.kubeRBACProxy.listenHost (.Values.service.port | int) }}

- --upstream=http://127.0.0.1:{{ $servicePort }}/
- --proxy-endpoints-port={{ .Values.kubeRBACProxy.proxyEndpointsPort }}
- --config-file=/etc/kube-rbac-proxy-config/config-file.yaml
Expand Down
3 changes: 3 additions & 0 deletions charts/prometheus-node-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ kubeRBACProxy:

# Specify the port used for the Node exporter container (upstream port)
port: 8100
# Host prefix for kube-rbac-proxy secure listen address.
# Keep ":" to listen on all interfaces, or set values like "127.0.0.1:" or "$(POD_IP):".

@zeritti zeritti Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Keep ":" to listen on all interfaces, or set values like "127.0.0.1:" or "$(POD_IP):".
# Keep default to listen on all interfaces, or set a custom value like "$(POD_IP)".

The only reasonable setting for the IP to listen on is the pod's IP (POD_IP). Setting an environment variable in the container from a fieldRef is currently not supported by the chart, though.

listenHost: ":"

@zeritti zeritti Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not set, the field's value is an empty string:

Suggested change
listenHost: ":"
listenHost: ""

# Specify the name of the container port
portName: http
# Configure a hostPort. If true, hostPort will be enabled in the container and set to service.port.
Expand Down