[prometheus-cloudwatch-exporter] add commonLabels support#6715
Open
firasmosbehi wants to merge 1 commit into
Open
[prometheus-cloudwatch-exporter] add commonLabels support#6715firasmosbehi wants to merge 1 commit into
firasmosbehi wants to merge 1 commit into
Conversation
Signed-off-by: Firas Mosbehi <firas.mosbehi@insat.ucar.tn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
commonLabelssupport toprometheus-cloudwatch-exporterresources and addresses #6247.Problem
The chart exposes resource-specific label knobs (
service.labels,deployment.labels, etc.) but lacks a global/common label mechanism. Users wanting organization-wide labels on all chart resources must duplicate labels per-resource or patch rendered manifests.Root cause
No top-level value exists to inject shared labels into metadata across all templates.
Fix
commonLabels: {}tovalues.yaml.commonLabelsinto metadata labels for all chart-rendered resources.commonLabelsin deployment pod template labels.PrometheusRuleandServiceMonitormetadata labels includecommonLabelseven when chart-specific label maps are empty.0.28.1to0.28.2.Validation
helm lint charts/prometheus-cloudwatch-exporterhelm template test charts/prometheus-cloudwatch-exporter --set commonLabels.team=platform --set serviceMonitor.enabled=true --set prometheusRule.enabled=trueteam: platformlabels across rendered resources.Compatibility
Backward compatible:
commonLabelsdefaults to{}and does not affect existing installs unless explicitly set.