Skip to content

[prometheus-blackbox-exporter] use kubernetes.io/metadata.name in networkPolicy #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firasmosbehi wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

[prometheus-blackbox-exporter] use kubernetes.io/metadata.name in networkPolicy #6713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-blackbox-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: Prometheus Blackbox Exporter
name: prometheus-blackbox-exporter
version: 11.8.0
version: 11.8.1
# renovate: github=prometheus/blackbox_exporter
appVersion: v0.28.0
kubeVersion: ">=1.21.0-0"
Expand Down
3 changes: 1 addition & 2 deletions charts/prometheus-blackbox-exporter/templates/networkpolicy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
- from:
- namespaceSelector:
matchLabels:
name: {{ .Values.networkPolicy.monitoringNamespaceName }}
kubernetes.io/metadata.name: {{ .Values.networkPolicy.monitoringNamespaceName }}

@monotek monotek Mar 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is changing the current default behaviour i consider this a breaking change.
Therefore major version of the chart woul dneed an update.
Maybe make key and value configurable so the current default can be kept.

ports:
- port: {{ .Values.service.port }}
protocol: TCP
Expand All @@ -25,4 +25,3 @@ spec:
policyTypes:
- Ingress
{{- end }}

3 changes: 2 additions & 1 deletion charts/prometheus-blackbox-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,8 @@ networkPolicy:
# Enable network policy and allow access from anywhere
enabled: false
# Limit access only from monitoring namespace
# Before setting this value to true, you must add the name=monitoring label to the monitoring namespace. Name can be rewritten by monitoringNamespaceName
# Before setting this value to true, the monitoring namespace must exist with
# kubernetes.io/metadata.name matching monitoringNamespaceName.
# Network Policy uses label filtering
allowMonitoringNamespace: false
# Rewrite monitoring namespace in network policy (default value monitoring)
Expand Down