[prometheus-fastly-exporter] add podLabels support#6712
Open
firasmosbehi wants to merge 1 commit into
Open
Conversation
Signed-off-by: Firas Mosbehi <firas.mosbehi@insat.ucar.tn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for custom pod labels in the
prometheus-fastly-exporterchart and addresses #6709.Problem
The chart exposed pod annotations but did not expose pod labels for the Deployment pod template. Users running GitOps workflows (for example Argo CD) could not reliably inject required standard pod labels without forking or post-render patching.
Root cause
templates/deployment.yamlonly rendered selector labels underspec.template.metadata.labels, andvalues.yamldid not define apodLabelsvalue.Fix
podLabelsin chart values with an empty-map default.podLabelswhen provided.0.11.0to0.11.1.Validation
helm lint charts/prometheus-fastly-exporterhelm template test charts/prometheus-fastly-exporter --set podLabels.team=platformand verified renderedteam: platformlabel in pod template metadata.Notes
This change is backward compatible because
podLabelsdefaults to{}and existing label behavior is preserved when unset.