Skip to content

fix(lang): use unicode.ToUpper in runeToUpper to handle uppercase input correctly #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karrybit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(lang): use unicode.ToUpper in runeToUpper to handle uppercase input correctly #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lang/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,13 @@ func runeIsUpper(r rune) bool {
return r >= 'A' && r <= 'Z'
}

const lowerToUpper = 'a' - 'A'

func runeToUpper(r rune) rune {
return r - lowerToUpper
}

func splitCamel(text string) string {
var builder strings.Builder
var previousRune rune
var wordLength int
for i, r := range text {
if i == 0 {
previousRune = runeToUpper(r)
previousRune = unicode.ToUpper(r)
continue
}

Expand Down