Refactor preCICE and domain decomposition handling#289
Merged
Conversation
Snapex2409
force-pushed
the
refactor-coupling
branch
from
acbaed6 to
b7d29b9
Compare
# Conflicts: # tests/unit/test_adaptivity_parallel.py # Conflicts: # micro_manager/adaptivity/global_adaptivity.py # micro_manager/load_balancing.py # micro_manager/micro_manager.py
could not split refactorings
Snapex2409
force-pushed
the
refactor-coupling
branch
from
d5be900 to
b660c8d
Compare
Snapex2409
changed the title
4 tasks
IshaanDesai
requested changes
Jun 17, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for this. The new design is a significant improvement. I have some suggestions and also some questions.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Collaborator
Author
|
Incorporated the requested changes, should be ready to merge now. |
IshaanDesai
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was initially intended to only refactor the handling of preCICE. However, since the interaction among preCICE, domain decomposition, and performance profiling was tightly intertwined, all these changes are now part of this PR.
The implemented changes are:
tools/coupling.pyusing theCouplingHandlerpartitionmethod splits the vertices obtained from the access region and returns the rank local points.Checklist:
CHANGELOG.md.