Skip to content

Use ColourHitErrorMeter in catch - #38269

Open
MingxuanGame wants to merge 5 commits into
ppy:masterfrom
MingxuanGame:feat/use-colour-hiterror-meter-for-catch
Open

Use ColourHitErrorMeter in catch#38269
MingxuanGame wants to merge 5 commits into
ppy:masterfrom
MingxuanGame:feat/use-colour-hiterror-meter-for-catch

Conversation

@MingxuanGame

Copy link
Copy Markdown

Moved HitErrorMeter into ruleset-only layer.

Judgement count, spacing and shape are referenced from Stable

@bdach bdach added the subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed. label Jul 13, 2026
@bdach

bdach commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Code seems mostly fine on a skim, but unsure of several subjective decisions made here.

  • The selected 1.25f judgement spacing on the meter looks bad / uneven:
    Screenshot 2026-07-13 at 12 23 59
    Also unsure on the overlap with the catcher on the classic skin.

  • Unsure about having two of these meters on argon & triangles, and still on the side too:
    Screenshot 2026-07-13 at 12 21 26

  • If we're entertaining per-ruleset placement of the error bar meter, then I'd say taiko should be adjusted because the current positioning of the left error meter is pretty bad in how it overlaps the drum:
    Screenshot 2026-07-13 at 12 21 45

Will need @peppy or someone design-adjacent to state preferences on all of the above.

@MingxuanGame

MingxuanGame commented Jul 13, 2026

Copy link
Copy Markdown
Author

The selected 1.25f judgement spacing on the meter looks bad / uneven

Maybe it depends on resolution. On my screen it isn't obvious.
image


Also unsure on the overlap with the catcher on the classic skin.

On stable the square is translucent with black background. (Add an option to set transparency?) Here is on stable.

image

For the third, I'm not familiar to taiko. If ruleset-specific hit error meter was considered, mania should be re-designed meanwhile because the bar is far from the playfield.

osu_2026-07-13_19-15-30

@bdach

bdach commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

On stable the square is translucent with black background. (Add an option to set transparency?) Here is on stable.

image

The black background is less the point than the fact that the catcher is higher up on stable, thus the hit error meter covers less of it than lazer.

@MingxuanGame

MingxuanGame commented Jul 13, 2026

Copy link
Copy Markdown
Author

The catcher is higher up on stable, thus the hit error meter covers less of it than lazer.

The catcher's scale depends on CS. Stable has the same issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:skinning size/L subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants