-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add WebSocket messages for beatmap data and user activity #38071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsunyoku
wants to merge
1
commit into
ppy:master
Choose a base branch
from
tsunyoku:add-basic-websocket-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−10
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using Newtonsoft.Json; | ||
| using osu.Game.Beatmaps; | ||
|
|
||
| namespace osu.Desktop.IPC.Messages | ||
| { | ||
| public class BeatmapMessage : OsuWebSocketMessage | ||
| { | ||
| [JsonProperty("beatmap_id")] | ||
| public required int BeatmapId { get; init; } | ||
|
|
||
| [JsonProperty("beatmap_set_id")] | ||
| public required int BeatmapSetId { get; init; } | ||
|
|
||
| [JsonProperty("beatmap_hash")] | ||
| public required string BeatmapHash { get; init; } | ||
|
|
||
| [JsonProperty("metadata")] | ||
| public required BeatmapMetadata Metadata { get; init; } | ||
|
|
||
| [JsonProperty("difficulty")] | ||
| public required BeatmapDifficulty Difficulty { get; init; } | ||
|
|
||
| [JsonProperty("difficulty_name")] | ||
| public required string DifficultyName { get; init; } | ||
|
|
||
| [JsonProperty("ruleset_id")] | ||
| public required int RulesetId { get; init; } | ||
|
|
||
| [JsonProperty("bpm")] | ||
| public required double BPM { get; init; } | ||
|
|
||
| [JsonProperty("star_rating")] | ||
| public required double StarRating { get; init; } | ||
|
|
||
| [JsonProperty("status")] | ||
| public required BeatmapOnlineStatus Status { get; init; } | ||
| } | ||
|
|
||
| public class BeatmapMetadata | ||
| { | ||
| [JsonProperty("artist")] | ||
| public required string Artist { get; init; } | ||
|
|
||
| [JsonProperty("artist_unicode")] | ||
| public required string ArtistUnicode { get; init; } | ||
|
|
||
| [JsonProperty("title")] | ||
| public required string Title { get; init; } | ||
|
|
||
| [JsonProperty("title_unicode")] | ||
| public required string TitleUnicode { get; init; } | ||
|
|
||
| [JsonProperty("author")] | ||
| public required string Author { get; init; } | ||
|
|
||
| [JsonProperty("source")] | ||
| public required string Source { get; init; } | ||
|
|
||
| [JsonProperty("tags")] | ||
| public required string Tags { get; init; } | ||
|
|
||
| [JsonProperty("user_tags")] | ||
| public required string[] UserTags { get; init; } | ||
| } | ||
|
|
||
| public class BeatmapDifficulty | ||
| { | ||
| [JsonProperty("approach_rate")] | ||
| public required double ApproachRate { get; init; } | ||
|
|
||
| [JsonProperty("circle_size")] | ||
| public required double CircleSize { get; init; } | ||
|
|
||
| [JsonProperty("overall_difficulty")] | ||
| public required double OverallDifficulty { get; init; } | ||
|
|
||
| [JsonProperty("drain_rate")] | ||
| public required double DrainRate { get; init; } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want this enum (and any future cases) to serialize as a string rather than an int, depending on what future documentation for the WebSocket may look like once it reaches a mature state.
Indifferent, would appreciate another opinion.