Add global alt scroll to adjust volume v2#38060
Open
RatinFX wants to merge 5 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR became rather stale, so I wanted to help the case.
Original PR:
Relevant issues:
This solution
The solution in this PR uses a blocker Interface that can be added to Containers such as
ZoomableScrollContainer.Alongside that it removes the old
GlobalScrollAdjustsVolumereferences.Alternatively we can also go with the original PR's route and add more Containers to the blocked list in the future.
Tests
I manually scrolled through the app: in solo, in multi, in ranked play, in the editor + its timeline with the
ZoomableScrollContainer.I also updated the existing test cases and added an extra one.
It's a bit up for debate whether it's in the right place or needs to further be separated into its own test scene.