Adding holding space during replays to temporary double the playback rate#38006
Draft
plinkuq wants to merge 4 commits into
Draft
Adding holding space during replays to temporary double the playback rate#38006plinkuq wants to merge 4 commits into
plinkuq wants to merge 4 commits into
Conversation
tried my best to add this the cleanest way possible there might be a better way of doing this, I also added tests
plinkuq
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
Wouldn't shift make more sense? Like dash from osu!catch? Zero sense makes to me having a "pause" binding accelerate playback when held. |
bdach
added
area:replay
subjective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YouTube added a feature that allows you to double the speed of a video by holding space and I thought it would be nice to add this to osu replays
This PR adds this feature into osu replays and adds tests for this feature as well
Video of changes:
final.mp4
This is my first pull request so any feedback would be appreciated