Skip to content

Show all keybinds in menu tips instead of only the first one#38004

Open
diquoks wants to merge 1 commit into
ppy:masterfrom
diquoks:quick-fix/keybinds-in-menu-tips
Open

Show all keybinds in menu tips instead of only the first one#38004
diquoks wants to merge 1 commit into
ppy:masterfrom
diquoks:quick-fix/keybinds-in-menu-tips

Conversation

@diquoks

@diquoks diquoks commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

i'm not sure why in #33863 i decided to go the hard way with GetReadableKeyCombinationsFor() & FirstOrDefault() and also breaking DRY, but it should be much better this way

@diquoks diquoks changed the title Show all keybinds instead of the first one in menu tips Show all keybinds instead of only the first one in menu tips Jun 5, 2026
@diquoks diquoks changed the title Show all keybinds instead of only the first one in menu tips Show all keybinds in menu tips instead of only the first one Jun 5, 2026
@bdach bdach added area:main menu subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed. labels Jun 9, 2026
@bdach

bdach commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Where is this coming from?

@diquoks

diquoks commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

PRs with subjective changes which have not been discussed prior. Need team consensus to proceed.

it was my personal initiative is to use a ready-made function here and display all possible keyboard shortcuts for the convenience of users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:main menu size/S subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants