Add bookmark feature for replays#37963
Open
antfaia wants to merge 2 commits into
Open
Conversation
Players can now set bookmarks while watching a replay and navigate between them using keyboard shortcuts: Ctrl+B – add bookmark at current playback position Ctrl+Shift+B – remove nearest bookmark Alt+Left – seek to previous bookmark Alt+Right – seek to next bookmark Bookmarks are persisted in the database alongside the score. They appear as small red markers on the song progress bar across all skin variants (Argon, Default/Triangles, Legacy), each with its own dedicated overlay component. UI (Visual) and Unit tests are included to validate the feature. Co-authored-by: António Faia <antonio.faia@tecnico.ulisboa.pt>
antfaia
changed the title
Co-authored-by: Simão Caixas <simaocaixas@tecnico.ulisboa.pt>
bdach
added
area:replay
subjective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the bookmark editor system, we implemented a bookmark system for replays.
This could improve the UX when watching replays, allowing players to save a specific playback time.
They work similar to the editor’s system and allow to:
(shortcuts defined by default)
Bookmark logic is managed by
ReplayBookmarkController.cs. Bookmarks are persisted in the database, attached to the corresponding score.Visually, bookmarks appear as small red markers on the song progress bar and work across Argon, Default and Legacy progress bars.
To ensure our feature was functional, we also decided to write some UI (
TestSceneReplayBookmark.cs) and Unit tests (ReplayBookmarkDatabaseTests.cs) to validate its functionality and guarantee everything is working as intended.ReplayBookmarksShowcase.mp4