fix: add Linux camera browser fallback - #289
Conversation
|
Update: I installed the missing Fedora development packages locally and reran the checks. |
FabienDanieau
left a comment
There was a problem hiding this comment.
Super nice, it's really useful. I've left some comments.
|
Thanks for the review, I updated the PR to address both points:
I reran the local checks after the change:
Let me know if you would prefer the external viewer glue to be factored further, but this should now avoid the duplicated low-level WebRTC logic. |
FabienDanieau
left a comment
There was a problem hiding this comment.
Just a minor refacto and we can merge!
| const errorIconColor = `${STATUS.error}99`; | ||
| const errorTextColor = `${STATUS.error}b3`; | ||
| const canOpenExternalViewer = | ||
| isWebRTCAvailable === false && error === 'WebRTC is not supported by this desktop WebView'; |
There was a problem hiding this comment.
you may compare to this variable https://github.com/kamjin3086/reachy-mini-desktop-app/blob/396941ea78e9cadb53612a61e86b040a4d555328/src/contexts/WebRTCStreamContext.tsx#L38 instead of the string
|
Thanks, fixed in the latest commit. I exported the existing I reran the checks locally:
Thanks again for the review! |
|
Thanks! Let's merge |
This PR extracts the Linux camera fallback work from #283, following the request to split it from the Fedora RPM packaging changes.
Summary:
Validation:
Notes: