-
Notifications
You must be signed in to change notification settings - Fork 219
MapPortHandler Callback for container support #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xinze-zheng
wants to merge
22
commits into
main
Choose a base branch
from
feat/port-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d4c6d70
Allow port mapping for all candidates
xinze-zheng 035192e
Fix lint
xinze-zheng 48e3922
Change Option API
xinze-zheng 5b36d87
Lint
xinze-zheng ddfeb35
Lint
xinze-zheng d6881a5
Fix test
xinze-zheng f20516c
Fix lint eventually
xinze-zheng bb40085
Merge branch 'master' into feat/port-map
xinze-zheng 88c64ee
Update test for compatibility
xinze-zheng 6112bf7
Use public API
xinze-zheng 460350f
Keep mappedPort private
xinze-zheng 220f152
Merge branch 'master' into feat/port-map
xinze-zheng 1e988ed
Update CI
xinze-zheng 5d2058f
Merge branch 'master' into feat/port-map
xinze-zheng 121cc45
MapPort now overwrite port
xinze-zheng 778c767
Merge branch 'master' into feat/port-map
xinze-zheng 874b26c
Fix mod
xinze-zheng 4b9f5d8
Fix nil exception
xinze-zheng 681b1c3
Fix test's resource leak
xinze-zheng e6905e5
More tests for MapPort
xinze-zheng 804a7ce
More tests for MapPort
xinze-zheng 3ded026
Remove candidate type filter
xinze-zheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll either need to remove the candidate type filter or make it possible to add multiple filters for different candidates types.
I think removing is better because the user filter have access to the candidate type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! Updated.