fix: support all shatel mobile phone number prefixes#29
Open
Nimasadollahi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I recently purchased a custom phone number from Shatel Mobile. While using your package in a Python project, I noticed that my number was flagged as invalid.
Looking at the repository, the regex pattern currently restricts Shatel Mobile numbers to the
99810through99822ranges, which matches this announcement from Shatel in late 2023. However, Shatel Mobile seems to have expanded its allocation, and my own phone number falls outside the latest announced number range.Therefor I have opened this pull request to update the regex so it accepts the wider
998prefix. I also verified that this prefix does not conflict with any other mobile operators.