Drop stale "instantly" claim from panic_note's source defaultValue - #1674
Open
krishrathi1 wants to merge 1 commit into
Open
Drop stale "instantly" claim from panic_note's source defaultValue#1674krishrathi1 wants to merge 1 commit into
krishrathi1 wants to merge 1 commit into
Conversation
permissionlesstech#1588 updated the Localizable.xcstrings catalog entry for app_info.settings.danger.panic_note to drop "instantly" once the triple-tap wipe gained a confirmation dialog, but left this Swift source's inline defaultValue (the extraction fallback, not what actually renders since the catalog entry takes precedence) still claiming the old instant, unconfirmed behavior. Brings the fallback back in sync with the catalog so a future extraction pass or catalog regen can't resurface the stale claim. Noticed while checking whether permissionlesstech#152 was resolved by permissionlesstech#1588 -- it was; this is the one loose end.
Chessing234
reviewed
Aug 25, 2026
Chessing234
left a comment
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
this defaultValue never renders — the catalog entry is what shows. please fold the string into a real code pr rather than a one-line fallback that nobody sees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny follow-up to #1588, found while checking whether #152 was resolved.
#1588 correctly updated
Localizable.xcstrings'sapp_info.settings.danger.panic_noteentry to drop the "instantly" claim once the triple-tap wipe gained a confirmation dialog. It didn't update the matchingdefaultValue:inAppInfoView.swift'sString(localized:defaultValue:)call -- that's just the extraction fallback (the catalog entry is what actually renders, since it exists), so nobody sees the wrong text today. But it's a live discrepancy in source: a future catalog regen or extraction pass reading only the Swift default would resurface "triple-tapping the bitchat/ logo does the same, instantly" as the caption text, silently reintroducing the exact claim #1588 removed.One line, brings the fallback back in sync with the catalog value.
No Xcode/Swift toolchain available here, so this is verified by reading -- confirmed the new defaultValue is character-for-character identical to the current
Localizable.xcstringsenvalue for this key, and thatpanicNotehas exactly one other call site (AppInfoView.swift:572, unaffected -- it renders the catalog value, not the default).