BANK-1321Fix raising correct error when some banks put business-level error codes in the header position - #13
Merged
Merged
Conversation
…des in the header position
vnovitskyi
changed the title
vnovitskyi
marked this pull request as ready for review
April 27, 2026 08:56
scollon-pl
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some banks return business-level EBICS error codes (e.g.
091210/EBICS_X509_WRONG_KEY_USAGE) in the header/technical position of the XML response rather than the body. The gem's middleware raisesTechnicalErrorfor header codes — butTechnicalError::ERRORSdoes not contain the key. The result is that valid, known errors are reported asEPICS_UNKNOWN - unknowninstead of their actual description.Before
After