Add URL-based configuration support for the ClickHouse adapter#1
Open
quentindemetz wants to merge 2 commits into
Open
Add URL-based configuration support for the ClickHouse adapter#1quentindemetz wants to merge 2 commits into
quentindemetz wants to merge 2 commits into
Conversation
Allows configuring the adapter via a single `url` key (e.g. `clickhouse://user:pass@host:8123/db?ssl=true`) instead of requiring every field to be specified individually. Explicit config keys take precedence over URL-parsed values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rails 7.2+ uses the `register` API which calls `ClickhouseAdapter.new` directly, bypassing `clickhouse_connection` where URL parsing lived. Move `parse_clickhouse_url` to a public class method on `ClickhouseAdapter` and call it from `initialize` so it works regardless of entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PNixx#200
urlkey (e.g.clickhouse://user:pass@host:8123/db) instead of specifying every connection field individuallyssl,debug,http_auth,read_timeout,write_timeout,keep_alive_timeout,cluster_name,sslcaTest plan
bundle exec rspec spec/single/url_config_spec.rb— 21 new tests covering basic URL, URL-encoded credentials, all query params, override behaviour, error cases, and backward compatibilitybundle exec rspec spec/single/http_auth_spec.rb— existing auth tests still passbundle exec rspec spec/single/— full single-node suite passes