BUG: Fix MultiIndex.equals regression regarding code bit-width (#65700)#65701
Open
anzinmhd wants to merge 8 commits into
Open
BUG: Fix MultiIndex.equals regression regarding code bit-width (#65700)#65701anzinmhd wants to merge 8 commits into
anzinmhd wants to merge 8 commits into
Conversation
Contributor
Author
|
pre-commit.ci autofix |
Member
|
Thanks for the PR! To preserve the speedup of #65192, we might still want to do the bytes-based comparison when the dtypes are the same. (and then maybe can add a |
Contributor
Author
|
pre-commit.ci autofix |
anzinmhd
force-pushed
the
fix-multiindex-equals-65700
branch
from
af1df55 to
4e24235
Compare
Contributor
Author
|
@jorisvandenbossche Thanks for the feedback! I've moved the _array_equivalent_int helper to the module level to avoid the inheritance issue and preserve the performance win from #65192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in MultiIndex.equals where equality was incorrectly failing when comparing codes with different bit-widths (e.g., int32 vs int64). This changes the equality check to be value-based rather than byte-based.
Issue: Closes #65700