Skip to content

add: xterm#8841

Open
itsdonnix wants to merge 16 commits into
pacstall:masterfrom
itsdonnix:xterm
Open

add: xterm#8841
itsdonnix wants to merge 16 commits into
pacstall:masterfrom
itsdonnix:xterm

Conversation

@itsdonnix

Copy link
Copy Markdown
Contributor

Progress

  • Edit packagelist
  • Add initial pacscript
  • Add maintainer to pacscript

Continuity of #7937

itsdonnix added 15 commits June 5, 2026 21:18
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Changed `lxterm.1` install mode from `755` to `644`
- Prevents executable manpage issue

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Improves portability by using POSIX-compliant command
- Ensures proper detection of `locale` availability

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Gzip man pages to match expected `.gz` extension
- Prevents broken symlink from `update-alternatives`
- Fixes issue with uncompressed man page references

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Use `printf '%s\n'` instead of `echo` for script and man file
- Ensures consistent behavior across shells
- Prevents issues with special characters or leading dashes

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Added `COPYING` as `LICENSE` under `/usr/share/licenses/xterm`
- Aligns with distro packaging guidelines for license placement
- Ensures compliance and improves discoverability

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Updates `pkgver` to latest upstream release

Signed-off-by: Don Alfons <donnisnoni@outlook.com>
- Move `lxterm` and `lxterm.1` from heredocs to separate source files
- Update `sha256sums` for new files
- Simplify `package()` by installing directly from `srcdir`
@github-actions github-actions Bot added the Package Add Use this to request a package to be added label Jun 5, 2026
Comment thread packages/xterm/xterm.pacscript Outdated
Comment thread packages/xterm/xterm.pacscript Outdated
Comment thread packages/xterm/xterm.pacscript Outdated
- Replace remote URLs for `lxterm` and `lxterm.1` with local source references
@itsdonnix itsdonnix requested a review from Elsie19 June 8, 2026 17:46
source=(
"@${pkgname}~${pkgver}::https://github.com/ThomasDickey/xterm-snapshots/archive/refs/tags/${pkgname}-${pkgver}.tar.gz"
"lxterm"
"lxterm.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, lxterm and its man page don't exist upstream (Thomas Dickey only includes uxterm). It is a Debian/Ubuntu-specific wrapper script.

Since Pacstall targets Debian/Ubuntu systems, we need it. I prefer keeping these managed manually as local files in the repo, similar to how the Debian packaging team handles them.

@itsdonnix itsdonnix requested a review from Elsie19 June 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package Add Use this to request a package to be added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants