Skip to content

Feature/wasm remote3#2104

Open
thibaudk wants to merge 31 commits into
masterfrom
feature/wasm-remote3
Open

Feature/wasm remote3#2104
thibaudk wants to merge 31 commits into
masterfrom
feature/wasm-remote3

Conversation

@thibaudk

@thibaudk thibaudk commented Jul 6, 2026

Copy link
Copy Markdown
Member

Update remote control path
forego HTML injection
accept .wasm requests
Enable CORS

@thibaudk
thibaudk requested a review from jcelerier July 6, 2026 17:43
@thibaudk
thibaudk force-pushed the feature/wasm-remote3 branch from 31beb64 to 95e5c60 Compare July 6, 2026 17:44
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.hpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.cpp Outdated
@jcelerier jcelerier mentioned this pull request Jul 9, 2026
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/Settings/Model.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/Http_server.hpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp Outdated
SETTINGS_PARAMETER_IMPL(Enabled){QStringLiteral("RemoteControl/Enabled"), false};
SETTINGS_PARAMETER_IMPL(WebUiPath){QStringLiteral("RemoteControl/WebUiPath"), ""};
SETTINGS_PARAMETER_IMPL(ServerAddress){QStringLiteral("RemoteControl/ServerAddress"), "0.0.0.0"};
SETTINGS_PARAMETER_IMPL(ServerPort){QStringLiteral("RemoteControl/ServerPort"), 8080};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should pick a less common port by default ?

Comment thread src/plugins/score-plugin-remotecontrol/RemoteControl/Settings/Model.cpp Outdated
Comment thread src/plugins/score-plugin-remotecontrol/CMakeLists.txt Outdated
Comment thread .gitignore
@thibaudk
thibaudk force-pushed the feature/wasm-remote3 branch from 79a57b8 to 35bdd55 Compare July 14, 2026 08:14
@thibaudk

Copy link
Copy Markdown
Member Author

I wanted to have a pop up message instead of using qDebug to handle errors...
Is there anything else ?

@jcelerier

Copy link
Copy Markdown
Member

@thibaudk For the error:


/__w/score/score/src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp:214:28: error: use of overloaded operator '<<' is ambiguous (with operand types 'QDebug' and 'std::string' (aka 'basic_string<char>'))
  214 |   qDebug() << what << ": " << ec.message();
      |   ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~

You need .c_str() as older Qt versions did not support qDebug() << std::string{};

@thibaudk

Copy link
Copy Markdown
Member Author

@thibaudk For the error:


/__w/score/score/src/plugins/score-plugin-remotecontrol/RemoteControl/HttpServer/HttpServer.cpp:214:28: error: use of overloaded operator '<<' is ambiguous (with operand types 'QDebug' and 'std::string' (aka 'basic_string<char>'))
  214 |   qDebug() << what << ": " << ec.message();
      |   ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~

You need .c_str() as older Qt versions did not support qDebug() << std::string{};

aaa ok, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants