Feature/wasm remote3#2104
Open
thibaudk wants to merge 31 commits into
Open
Conversation
thibaudk
force-pushed
the
feature/wasm-remote3
branch
from
July 6, 2026 17:44
31beb64 to
95e5c60
Compare
jcelerier
requested changes
Jul 7, 2026
jcelerier
reviewed
Jul 8, 2026
jcelerier
reviewed
Jul 8, 2026
Closed
jcelerier
reviewed
Jul 11, 2026
jcelerier
reviewed
Jul 11, 2026
jcelerier
reviewed
Jul 12, 2026
jcelerier
requested changes
Jul 12, 2026
| SETTINGS_PARAMETER_IMPL(Enabled){QStringLiteral("RemoteControl/Enabled"), false}; | ||
| SETTINGS_PARAMETER_IMPL(WebUiPath){QStringLiteral("RemoteControl/WebUiPath"), ""}; | ||
| SETTINGS_PARAMETER_IMPL(ServerAddress){QStringLiteral("RemoteControl/ServerAddress"), "0.0.0.0"}; | ||
| SETTINGS_PARAMETER_IMPL(ServerPort){QStringLiteral("RemoteControl/ServerPort"), 8080}; |
Member
There was a problem hiding this comment.
Maybe we should pick a less common port by default ?
thibaudk
force-pushed
the
feature/wasm-remote3
branch
from
July 14, 2026 08:14
79a57b8 to
35bdd55
Compare
Member
Author
|
I wanted to have a pop up message instead of using qDebug to handle errors... |
Member
|
@thibaudk For the error: You need .c_str() as older Qt versions did not support qDebug() << std::string{}; |
Member
Author
aaa ok, thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update remote control path
forego HTML injection
accept .wasm requests
Enable CORS