Simplify Ruby installation in Docker#12044
Open
sschuberth wants to merge 2 commits into
Open
Conversation
See [1]. [1]: https://github.com/licensee/licensee/releases/tag/v10.0.0 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
sschuberth
force-pushed
the
licensee-no-rugged
branch
from
17a4e6f to
9499471
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12044 +/- ##
=========================================
Coverage 58.53% 58.53%
Complexity 1821 1821
=========================================
Files 361 361
Lines 13551 13551
Branches 1399 1399
=========================================
Hits 7932 7932
Misses 5117 5117
Partials 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sschuberth
force-pushed
the
licensee-no-rugged
branch
2 times, most recently
from
c90e891 to
4830b13
Compare
Now that the "rugged" dependency of `licensee` is optional [1], also "cmake" and "openssl" are not needed anymore. Go even further in simplifying things by giving `mise` [2] a try to install Ruby in the Docker image. [1]: licensee/licensee#66 [2]: https://mise.jdx.dev/mise-cookbook/docker.html Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
sschuberth
force-pushed
the
licensee-no-rugged
branch
from
4830b13 to
edc3bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.