feat: upgrade opencc to 1.4.0#2039
Draft
Bambooin wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build logic and native build configuration to support upgrading OpenCC to 1.4.0, primarily by aligning packaged OpenCC dictionary data and ensuring required Boost components are available for the native build.
Changes:
- Update the OpenCC data install task to package an updated set of OpenCC dictionary text files and adjust which reverse dictionaries are generated.
- Expand the Boost CMake include list to include additional Boost components (
preprocessor,vmd) needed by downstream native dependencies.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build-logic/convention/src/main/kotlin/OpenCCDataPlugin.kt | Updates the list of OpenCC dictionaries that get copied/generated into the app’s packaged shared/opencc assets. |
| app/src/main/jni/cmake/Boost.cmake | Adds Boost components to the curated Boost build used by the native (CMake) build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
66
to
+70
| companion object { | ||
| private val DICTS_RAW = | ||
| arrayOf( | ||
| "CJK_Compatibility_Ideographs", | ||
| "HKPhrasesRev", |
Collaborator
|
OpenCC makes frequent changes recently, the latest librime 1.17.0 doesn't adapt to the latest OpenCC 1.4.0, so I think this PR can be delayed until librime is ready for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #
Fixes #
Feature
Describe features of this pull request
Upgrade OpenCC to 1.4.0.
There is one issue with this pull request, the simplified Chinese is missing.
Anyone has the agent can fix this issue and contribute it here.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info