Conversation
Bumps [actions/stale](https://github.com/actions/stale) from 10.2.0 to 10.3.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@b5d41d4...eb5cf3a) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2244) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 8.0.0 to 8.1.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@59db25f...7006c44) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-version: 8.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.5 to 4.36.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@9e0d7b8...7211b7c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…hts (#2242) * feat: add SLSA build provenance attestation and update security insights Signed-off-by: Simon Essien <champbreed1@gmail.com> * build: force-refresh github pr sync state Signed-off-by: Simon Essien <champbreed1@gmail.com> --------- Signed-off-by: Simon Essien <champbreed1@gmail.com>
* fix: ssp-generate KeyError on missing profile-param-value-origin dict.pop() without a default value raises KeyError when profile-param-value-origin key is absent from the parameter dict in _construct_set_parameters_dict. Add None as default to handle missing key gracefully. Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> * test: add deterministic unit tests for all KeyError paths in _construct_set_parameters_dict (#2221) Three code paths where PROFILE_PARAM_VALUE_ORIGIN is never written into new_dict but pop() is called — all now covered: Path 1: prof_param_value_origin == '' + AGGREGATES in profile param → test_construct_set_parameters_dict_aggregates_no_origin_unit Path 2: prof_param_value_origin != '' + purpose=SSP + AGGREGATES in control → test_construct_set_parameters_dict_aggregates_with_prof_origin_ssp Path 3: prof_param_value_origin != '' + purpose=PROFILE + AGGREGATES in both → test_construct_set_parameters_dict_aggregates_with_prof_origin_profile_purpose Also added test_ssp_generate_missing_profile_param_value_origin_regression which uses profile_aggregation fixture (exercises AGGREGATES branch via SSPGenerate._run) as a higher-level regression guard. All tests fail deterministically on unpatched code. Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> * style: apply code-format and mdformat fixes for lint complianc Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> * chore: remove accidentally tracked venv.trestle-contrib files Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> * refactor: move imports to module level and add smoke test clarification - Move Parameter1, Property, CatalogWriter imports to module level (ContextPurpose, ControlContext were already at module level) - Add NOTE to test_ssp_generate_missing_profile_param_value_origin clarifying it does not exercise the AGGREGATES branch and is kept as a smoke test only Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> * fix: replace fragile __new__ bypass with Mock(spec=CatalogInterface) in unit tests Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> --------- Signed-off-by: s1ns3nz0 <s1ns3nz0@gmail.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
* feat: add RFC 8785 canonical JSON helpers Signed-off-by: Matteo Fari <matteofari06@gmail.com> * feat: add canonicalize command Signed-off-by: Matteo Fari <matteofari06@gmail.com> * feat: add canonical JSON model support and documentation Signed-off-by: Matteo Fari <matteofari06@gmail.com> * fix: write canonical JSON for .canonical.json paths Signed-off-by: Matteo Fari <matteofari06@gmail.com> --------- Signed-off-by: Matteo Fari <matteofari06@gmail.com>
* fix: url validation Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: improve security test Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: degenaro <lou.degenaro@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@de0fac2...df4cb1c) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.0 to 4.36.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@7211b7c...8aad20d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.36.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
#2261) Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases) - [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md) - [Commits](sigstore/gh-action-sigstore-python@04cffa1...5b79a39) --- updated-dependencies: - dependency-name: sigstore/gh-action-sigstore-python dependency-version: 3.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
…#2260) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 8.1.0 to 8.2.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@7006c44...7138816) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-version: 8.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
* fix: url code 429 implies existence Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: configure explicit warn on 429 Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: htmlproofer 429 Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: htmlproofer raise error after finish Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: degenaro <lou.degenaro@gmail.com>
* feat: add xlsx-to-oscal-poam task for OSCAL POAM generation Adds XlsxToOscalPoam task that transforms FedRAMP POAM Excel spreadsheets into OSCAL POAM JSON format, with supporting tests, test fixtures, and tutorial. Signed-off-by: allanilya <allanilyasov@gmail.com> * refactor: format dictionary unpacking for improved readability in xlsx_to_oscal_poam Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: use AssociatedRisk and apply ruff formatting Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: update risk status assertion and improve validation checks in xlsx_to_oscal_poam Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: header & improve code quality Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: header & improve test coverage Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: add xlsx format info to -i info Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: allanilya <allanilyasov@gmail.com> Signed-off-by: degenaro <lou.degenaro@gmail.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
* fix: sonar Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint regular expression Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: code-format Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: degenaro <lou.degenaro@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.3 to 7.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@df4cb1c...9c091bb) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: update nist-content submodule pointer to track latest main branch Signed-off-by: Simon Essien <champbreed1@gmail.com> * feat: add xlsx-to-oscal-poam task (#2219) * feat: add xlsx-to-oscal-poam task for OSCAL POAM generation Adds XlsxToOscalPoam task that transforms FedRAMP POAM Excel spreadsheets into OSCAL POAM JSON format, with supporting tests, test fixtures, and tutorial. Signed-off-by: allanilya <allanilyasov@gmail.com> * refactor: format dictionary unpacking for improved readability in xlsx_to_oscal_poam Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: use AssociatedRisk and apply ruff formatting Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: update risk status assertion and improve validation checks in xlsx_to_oscal_poam Signed-off-by: allanilya <allanilyasov@gmail.com> * fix: header & improve code quality Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: header & improve test coverage Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: add xlsx format info to -i info Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: allanilya <allanilyasov@gmail.com> Signed-off-by: degenaro <lou.degenaro@gmail.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com> * fix: snyk unrestricted, now compatible with pip (#2263) Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar (#2264) * fix: sonar Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: sonar complaint regular expression Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: code-format Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix: update test assertions to match nist-content v1.5.0 Signed-off-by: Simon Essien <champbreed1@gmail.com> * fix: DCO sign-off for previous merge commits Signed-off-by: Simon Essien <champbreed1@gmail.com> --------- Signed-off-by: Simon Essien <champbreed1@gmail.com> Signed-off-by: allanilya <allanilyasov@gmail.com> Signed-off-by: degenaro <lou.degenaro@gmail.com> Co-authored-by: Lou DeGenaro <lou.degenaro@gmail.com> Co-authored-by: Allan <132115536+allanilya@users.noreply.github.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Key links:
Before you merge