This repository was archived by the owner on Jan 26, 2021. It is now read-only.
Add roam-link company completion - #15
Open
alan-carroll wants to merge 8 commits into
Open
Conversation
- Add conditional to company-org-roam--get-candidates to check if completion is for a roam-link or not. If completion is for a roam-link, include in-buffer candidates for TITLEs that are not part of the org-roam database yet - Add conditional to company-org-roam--post-completion to check if completion is for a roam-link or not. If completion is for a roam-link either insert plain TITLE (completion inside [[roam:]] syntax) or insert complete roam link (org-roam-use-roam-links is t)
jethrokuan
reviewed
May 11, 2020
jethrokuan
left a comment
jethrokuan
left a comment
Member
There was a problem hiding this comment.
LGTM mostly, just needs the other PR cleaned up first.
Co-authored-by: Jethro Kuan <jethrokuan95@gmail.com>
jethrokuan
reviewed
May 11, 2020
| (if (or (string= "roam" (org-element-property :type (org-element-context))) | ||
| org-roam-use-roam-links) | ||
| (if (or org-roam-use-roam-links | ||
| (string= "roam" (org-element-property :type (org-element-context)))) |
Member
There was a problem hiding this comment.
the indentation looks a bit off here, my suggestion was typed in github, so I didn't get it right 😅
Author
There was a problem hiding this comment.
It should be fixed in the last commit 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For org-roam/org-roam#592
completion is for a roam-link or not.
If completion is for a roam-link, include in-buffer candidates for
TITLEs that are not part of the org-roam database yet
completion is for a roam-link or not.
If completion is for a roam-link either insert plain
TITLE (completion inside
[[roam:]]syntax) or insert complete roamlink (
org-roam-use-roam-linksist)