Fix : MCP2515 initialisation now respects filters and rollover to RXB1 - #1486
Open
wayne-love wants to merge 2 commits into
Open
Fix : MCP2515 initialisation now respects filters and rollover to RXB1#1486wayne-love wants to merge 2 commits into
wayne-love wants to merge 2 commits into
Conversation
Member
|
You're probably right regarding the acceptance filter mode needing activation in Your rollover change doesn't make any sense. The rollover is already enabled (as commented) and you try to set a read-only copy of the control bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1485.
MCP2515 was being initialised to accept all (ignore filters) and rollover was disabled (contrary to the code comments). I'm not a MCP2515 expert but the changes seem sound and test ok on my Leaf.