Skip to content

WIP: test #80493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eggfoobar wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

WIP: test #80493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...egistry/openshift/edge-tooling/gh-notifier/openshift-edge-tooling-gh-notifier-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ bash -c "set -euo pipefail; ${GH_NOTIFIER_INVOKE}"
# ---------------------------------------------------------------------------
cp -f "./gh-notifier/pr-dashboard.html" "${ARTIFACT_DIR}/edge-tooling-pr-summary.html"
echo "Copied ./gh-notifier/pr-dashboard.html to ${ARTIFACT_DIR}/edge-tooling-pr-summary.html (Spyglass + GCS)."

sleep 5000

@coderabbitai coderabbitai Bot Jun 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Remove the hard-coded 5000s idle delay on the job path.

Line 69 blocks the step for ~83 minutes after work is done, which unnecessarily ties up CI capacity and delays periodic job completion for pr-notifier. This is a runtime behavior regression without functional benefit.

Suggested fix 
- sleep 5000
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
sleep 5000
# (context before line 69)
# (no sleep statement - line 69 is removed)
# (any context after line 69 continues normally)
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/openshift/edge-tooling/gh-notifier/openshift-edge-tooling-gh-notifier-commands.sh`
at line 69, The hard-coded sleep 5000 command in the
openshift-edge-tooling-gh-notifier-commands.sh script is unnecessarily blocking
execution for approximately 83 minutes after work is completed, which wastes CI
capacity and delays job completion. Remove the sleep 5000 line entirely from the
script to allow the step to complete immediately after its functional work is
done, eliminating this runtime behavior regression.