Skip to content

Spot check jobs for azure v7 instances on 4.13-4.22#80478

Open
sdodson wants to merge 1 commit into
openshift:mainfrom
sdodson:azurev7instances
Open

Spot check jobs for azure v7 instances on 4.13-4.22#80478
sdodson wants to merge 1 commit into
openshift:mainfrom
sdodson:azurev7instances

Conversation

@sdodson

@sdodson sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member

Adds e2e-azure-v7-ovn-upgrade periodic jobs for OCP 4.13 through 4.22, mirroring the equivalent job added for 5.0 in #80373.

What's changed

  • Introduces e2e-azure-v7-ovn-upgrade in each of ci-4.13 through ci-4.22 variants
  • Job is a periodic upgrade-conformance run (workflow: openshift-upgrade-azure-ovn) with interval: 720h (30 days)
  • Constrains the Azure region to eastus via CUSTOM_AZURE_REGION: eastus (where v7 instances are available)
  • Uses v7 instance families: COMPUTE_NODE_TYPE: Standard_D4s_v7 and CONTROL_PLANE_INSTANCE_TYPE: Standard_D8s_v7
  • Sets FAIL_ON_CORE_DUMP: "true" and includes observers-resource-watch
  • All jobs have pj-rehearse.openshift.io/can-be-rehearsed: "true" to allow rehearsal testing

Test plan

  • Rehearse against representative versions (e.g. 4.18, 4.22) to confirm Azure v7 instance availability in eastus
  • Verify upgrade-conformance passes end-to-end on at least one older stream

Summary by CodeRabbit

This PR extends OpenShift's CI infrastructure to validate Azure v7 virtual machine instances across multiple release streams. Specifically, it adds a new periodic spot-check job called e2e-azure-v7-ovn-upgrade to the CI configuration files for OpenShift versions 4.13 through 4.22 (in the release repository).

The new job:

  • Runs as a periodic upgrade-conformance test every 30 days (720h interval)
  • Tests Azure infrastructure using v7-generation instance types: Standard_D4s_v7 for compute nodes and Standard_D8s_v7 for control plane nodes
  • Restricts testing to the eastus Azure region
  • Executes the openshift-upgrade-azure-ovn workflow with core-dump failure detection enabled
  • Uses a pre-configuration chain that includes Azure IPI setup, custom region configuration, OVN networking configuration, and RBAC setup
  • Includes resource-watch observers for comprehensive monitoring
  • Is marked as rehearsable (can be tested during PR rehearsal)

This mirrors functionality previously added for the 5.0 release stream, bringing consistency across the actively maintained release versions. The job allows OpenShift's continuous integration to periodically verify that Azure's newer v7 instance family works correctly with OpenShift across multiple release versions during upgrade scenarios.

Adds e2e-azure-v7-ovn-upgrade periodic jobs for OCP 4.13 through 4.22,
mirroring the equivalent job added for 5.0 in PR openshift#80373. Uses Standard_D4s_v7
compute and Standard_D8s_v7 control plane instances in eastus (where v7
instances are available), with a 30-day (720h) cadence.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@openshift-ci openshift-ci Bot requested review from petr-muller and xueqzhan June 12, 2026 16:08
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 138d5709-97f4-478a-9524-d1a12101a545

📥 Commits

Reviewing files that changed from the base of the PR and between be29100 and 4058064.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (10)
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.13.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.14.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.15.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.16.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.17.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.18.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.19.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.20.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.21.yaml
  • ci-operator/config/openshift/release/openshift-release-main__ci-4.22.yaml

Walkthrough

This pull request adds identical Azure OVN upgrade end-to-end test configuration (e2e-azure-v7-ovn-upgrade) across all OpenShift release branches (versions 4.13 through 4.22). Each addition defines a 720-hour interval test running on the Azure cluster profile with specific V7 instance types, upgrade-conformance settings, and a prerequisite chain of Azure IPI configuration and RBAC setup before executing the upgrade workflow.

Changes

Azure OVN Upgrade E2E Test Addition

Layer / File(s) Summary
Azure OVN upgrade test job added to version branches
ci-operator/config/openshift/release/openshift-release-main__ci-4.13.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.14.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.15.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.16.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.17.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.18.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.19.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.20.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.21.yaml, ci-operator/config/openshift/release/openshift-release-main__ci-4.22.yaml
New e2e-azure-v7-ovn-upgrade test job added across all release branches with consistent configuration: 720h scheduling interval, Azure V7 compute/control-plane sizing, CUSTOM_AZURE_REGION, FAIL_ON_CORE_DUMP: "true", TEST_TYPE: upgrade-conformance, enabled observers-resource-watch, and a pre chain including ipi-conf-azure, ipi-conf-azure-custom-region, ovn-conf, ipi-install-stableinitial, and ipi-azure-rbac before executing openshift-upgrade-azure-ovn workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • stbenjam
  • neisw
  • hector-vido
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the primary change: adding spot-check jobs for Azure v7 instances across OpenShift versions 4.13-4.22.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds static CI job entries (e2e-azure-v7-ovn-upgrade) to ci YAML; scanned changed .go files for ginkgo It/Describe/Context/When patterns and found zero matches.
Test Structure And Quality ✅ Passed PR changes only OpenShift release CI YAML job entries (e2e-azure-v7-ovn-upgrade); this repo has no Go files importing Ginkgo, so no Ginkgo test code quality issues to flag.
Microshift Test Compatibility ✅ Passed PR #80478 only adds periodic CI config entries in ci-operator/config/openshift/release/*.yaml (20 additions, no Go/Ginkgo test code), so no new MicroShift-incompatible Ginkgo tests were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80478 only adds YAML periodic job entries (e2e-azure-v7-ovn-upgrade) to ci-4.13..ci-4.22; no new Ginkgo/Go e2e test code was added, so no SNO assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only ci-operator YAML periodic test entries (e2e-azure-v7-ovn-upgrade) with env/pre/workflow; no affinity/spread/nodeSelector/topology constraints in deployment/controller manifests.
Ote Binary Stdout Contract ✅ Passed PR only adds periodic Azure v7 upgrade E2E jobs in ci-operator YAML; no OTE/openshift-tests binary or process-level stdout code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds periodic CI YAML jobs (e2e-azure-v7-ovn-upgrade) for 4.13-4.22; no new Ginkgo/e2e test code or IPv4 assumptions/connectivity changes were found in the added config.
No-Weak-Crypto ✅ Passed Scanned ci-operator/config/openshift/release/openshift-release-main__ci-4.{13..22}.yaml for md5/sha1/des/rc4/3des/blowfish/ecb/ECB and token/secret comparison patterns; none found while e2e-azure-v...
Container-Privileges ✅ Passed Scanned the modified ci-4.13–4.22 configs and openshift-release-main-periodics.yaml for privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/runAsUser:0; none appear in e2e-azu...
No-Sensitive-Data-In-Logs ✅ Passed Scanned ci-operator/config/openshift/release/openshift-release-main__ci-4.{13..22}.yaml for the new e2e-azure-v7-ovn-upgrade job; no password/token/secret/API key/PII/internal hostname strings foun...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sdodson: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-ci-4.16-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.17-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.15-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.20-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.19-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.14-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.18-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed
periodic-ci-openshift-release-main-ci-4.13-e2e-azure-v7-ovn-upgrade N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade periodic-ci-openshift-release-main-ci-4.17-e2e-azure-v7-ovn-upgrade periodic-ci-openshift-release-main-ci-4.14-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.17-e2e-azure-v7-ovn-upgrade periodic-ci-openshift-release-main-ci-4.14-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.18-e2e-azure-v7-ovn-upgrade periodic-ci-openshift-release-main-ci-4.15-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.20-e2e-azure-v7-ovn-upgrade periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sdodson

sdodson commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse more

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

@sdodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.21-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.15-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.15-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.19-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.19-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.17-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.17-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.14-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.14-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.18-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.18-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.20-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.20-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.13-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.13-e2e-azure-v7-ovn-upgrade
ci/rehearse/periodic-ci-openshift-release-main-ci-4.16-e2e-azure-v7-ovn-upgrade 4058064 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.16-e2e-azure-v7-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson

sdodson commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ci/rehearse/periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sdodson: job(s): ci/rehearse/periodic-ci-openshift-release-main-ci-4.22-e2e-azure-v7-ovn-upgrade either don't exist or were not found to be affected, and cannot be rehearsed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant