Disable gke-nongroovy-e2e-tests on PRs for stackrox/stackrox

[AlexVulaj]

PR coverage is now handled by GHA (e2e-nongroovy-tests.yaml). Prow job remains available for manual triggering and nightlies.

Generated by Claude Code

Summary by CodeRabbit

This PR updates the OpenShift CI configuration for the stackrox/stackrox repository to stop automatically running the gke-nongroovy-e2e-tests job on pull requests.

What changed: in ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml the gke-nongroovy-e2e-tests entry was set to always_run: false and optional: true (the job is no longer mandatory for PR validation).

Why: PR-level non-Groovy end-to-end testing is now performed by a GitHub Actions workflow (e2e-nongroovy-tests.yaml). The Prow job is retained for manual invocation and scheduled/nightly runs to preserve coverage without running on every PR.

Impact: reduces redundant PR test execution by moving PR validation for these GKE non-Groovy e2e tests to GitHub Actions while keeping Prow available for manual and nightly use.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 30de88fa-0897-46f4-a72c-5d0baee612b0

📥 Commits

Reviewing files that changed from the base of the PR and between bab5124 and 9e4ae82.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml

---

Walkthrough

The Stackrox CI configuration is updated to make the gke-nongroovy-e2e-tests job non-mandatory: always_run changed from true to false and optional: true was added.

Changes

CI Test Job Scheduling

Layer / File(s)	Summary
Make gke-nongroovy-e2e-tests optional ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml	The gke-nongroovy-e2e-tests job scheduling configuration is updated: always_run is set to false and optional: true is added, transitioning the test from mandatory to optional execution in the CI pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	❓ Inconclusive	Custom check execution failed before a final verdict was produced.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: disabling the gke-nongroovy-e2e-tests job on pull requests for stackrox/stackrox, which matches the configuration change from always_run: true to always_run: false.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR changes only ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml, setting gke-nongroovy-e2e-tests always_run:false and optional:true; file has no Ginkgo It/Describe/Context/When t...
Test Structure And Quality	✅ Passed	PASS: PR #80477 changes only ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml; no Ginkgo test (It/Describe) code is part of the PR, so the test-structure quality check is not appl...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR #80477 changes only ci-operator/config/stackrox/.../stackrox-stackrox-master.yaml (gke-nongroovy-e2e-tests always_run false + optional true); no new Ginkgo e2e test code is added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR #80477 only updates Stackrox Prow CI job config: gke-nongroovy-e2e-tests always_run true→false and adds optional:true; no scheduling constraints/affinity/topology logic changed.
Ote Binary Stdout Contract	✅ Passed	PR #80477 only updates ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml (always_run true→false; optional: true). No OTE binary/Go stdout code changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR 80477 only updates stackrox CI YAML (gke-nongroovy-e2e-tests always_run=false, optional:true) and no changed Go files contain Ginkgo/e2e test constructs or IPv4/external connectivity assumptions.
No-Weak-Crypto	✅ Passed	PR changes only stackrox-stackrox-master.yaml: gke-nongroovy-e2e-tests always_run true→false and optional:true. No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB/crypto/non-CT comparisons found in the diff/file.
Container-Privileges	✅ Passed	PR #80477 only flips always_run/optional for gke-nongroovy-e2e-tests; stackrox-stackrox-master.yaml contains no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/securityCon...
No-Sensitive-Data-In-Logs	✅ Passed	PR #80477 changes only gke-nongroovy-e2e-tests config (always_run true->false, optional true); no logging/pw/token/PII/hostname/customer data introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@AlexVulaj: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests	stackrox/stackrox	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[davdhacs]

/hold
Setting blocker for us to manually un-gate merging this after we've removed(renamed) the check_required for this job from the github repo ruleset: https://github.com/stackrox/automation-iac/pull/193

[davdhacs]

/lgtm
(if the switch is approved by @msugakov)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, davdhacs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/stackrox/OWNERS [davdhacs]
• ci-operator/jobs/stackrox/stackrox/OWNERS [davdhacs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davdhacs]

/assign @davdhacs

[msugakov]

(regarding PR description) Why not enable GHA-based tests for nightlies?