openstack: inherit TEST_ARGS in openstack-tests steps#80459
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughStep registry refs add a ChangesTEST_ARGS Environment Variable Propagation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
infra issues? /pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The chain-level TEST_ARGS=--disable-monitor=termination-message-policy
only affected the openshift-e2e-test step (step 1 of the chain). Both
openstack-test-openstack-commands.sh and openstack-test-openstack-ote-
commands.sh were clobbering TEST_ARGS with 'declare TEST_ARGS=""',
so the monitor was still running in step 2.
Change to 'declare TEST_ARGS="${TEST_ARGS:-}"' so the scripts
inherit the chain's value.
mandre
force-pushed
the
openstack-test-test-args
branch
from
a7cafe2 to
bc89a80
Compare
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 929 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-openstack-ovn |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
The chain-level TEST_ARGS=--disable-monitor=termination-message-policy only affected the openshift-e2e-test step (step 1 of the chain). Both openstack-test-openstack-commands.sh and openstack-test-openstack-ote- commands.sh were clobbering TEST_ARGS with 'declare TEST_ARGS=""', so the monitor was still running in step 2.
Change to 'declare TEST_ARGS="${TEST_ARGS:-}"' so the scripts inherit the chain's value.
Summary by CodeRabbit
This PR fixes environment variable inheritance in the OpenShift CI OpenStack test chain (ci-operator step-registry). Two step command scripts were unconditionally resetting TEST_ARGS to an empty string, preventing a chain-level TEST_ARGS value (e.g. --disable-monitor=termination-message-policy) from applying to later steps.
Practical changes:
Both scripts now initialize TEST_ARGS with parameter expansion (declare TEST_ARGS="${TEST_ARGS:-}") instead of a literal empty string, so they inherit any TEST_ARGS set at the chain/job level while still defaulting to empty when unset.
Configuration additions:
Both ref YAMLs add a TEST_ARGS env entry with a default empty string and documentation describing it as additional arguments passed to (openstack-)openshift-tests.
Effect: