Skip to content

ForceIPHTTPAdapter bug fix - #77

Merged
sadrasabouri merged 4 commits into
devfrom
force_ip_bug_fix
Oct 26, 2025
Merged

ForceIPHTTPAdapter bug fix#77
sadrasabouri merged 4 commits into
devfrom
force_ip_bug_fix

Conversation

@sepandhaghighi

Copy link
Copy Markdown
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • ForceIPHTTPAdapter class bug fixed

Any other comments?

@sepandhaghighi sepandhaghighi added this to the ipspot v0.6 milestone Oct 25, 2025
@sepandhaghighi sepandhaghighi self-assigned this Oct 25, 2025
@sepandhaghighi sepandhaghighi added the bug Something isn't working label Oct 25, 2025
@codecov-commenter

codecov-commenter commented Oct 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.69%. Comparing base (dfb007b) to head (05232a8).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
+ Coverage   77.66%   77.69%   +0.02%     
==========================================
  Files           4        4              
  Lines         394      390       -4     
  Branches       42       41       -1     
==========================================
- Hits          306      303       -3     
  Misses         70       70              
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi

Copy link
Copy Markdown
Member Author

In the previous version of the ForceIPHTTPAdapter class (known as IPv4HTTPAdapter in version 0.5), there was a major bug. This bug occasionally prevented socket.getaddrinfo from reverting to its original value, making it practically impossible to switch between IP versions.

Before:

ipspot_bug2

After:

ipspot_bug3

@sepandhaghighi
sepandhaghighi marked this pull request as ready for review October 25, 2025 18:53

@sadrasabouri sadrasabouri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, looks good to me.

@sadrasabouri
sadrasabouri merged commit d19a766 into dev Oct 26, 2025
22 checks passed
@sadrasabouri
sadrasabouri deleted the force_ip_bug_fix branch October 26, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants