Refactor - #75
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #75 +/- ##
==========================================
- Coverage 79.46% 79.31% -0.15%
==========================================
Files 4 4
Lines 375 382 +7
Branches 40 41 +1
==========================================
+ Hits 298 303 +5
- Misses 60 61 +1
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sepandhaghighi
marked this pull request as ready for review
October 22, 2025 21:53
Comment on lines
+26
to
+27
| if self.version not in ("ipv4", "ipv6"): | ||
| raise ValueError("version must be either 'ipv4' or 'ipv6'") |
Member
There was a problem hiding this comment.
Note for future: these should be in params.py
sadrasabouri
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
ForceIPHTTPAdapterclass added_get_json_force_ipfunction addedIPv4HTTPAdapterclass removed_get_json_ipv4_forcedfunction removedAny other comments?