New API: my-ip.io - #73
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #73 +/- ##
==========================================
- Coverage 81.31% 79.46% -1.86%
==========================================
Files 4 4
Lines 364 375 +11
Branches 39 40 +1
==========================================
+ Hits 296 298 +2
- Misses 51 60 +9
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sepandhaghighi
marked this pull request as ready for review
October 14, 2025 15:20
Member
|
I'm testing this on a system with ipv6 access and getting time "Max retries" (I only ran it once on this network): Is this going to be a problem? |
| :param timeout: timeout value for API | ||
| """ | ||
| try: | ||
| data = _get_json_standard(url="https://api6.my-ip.io/v2/ip.json", timeout=timeout) |
Member
There was a problem hiding this comment.
Also I'm getting "DNS_PROBE_FINISHED_NXDOMAIN" when opening this link in my browser.
Member
Author
There was a problem hiding this comment.
I believe this issue is related to your network. I tested it, and it worked perfectly!
sadrasabouri
approved these changes
Oct 16, 2025
sadrasabouri
left a comment
Member
There was a problem hiding this comment.
I tested it now it works good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?