This repository was archived by the owner on Nov 6, 2020. It is now read-only.
ethcore/test_helpers: fix deadlock caused by double read lock#11767
Open
BurtonQin wants to merge 1 commit into
Open
ethcore/test_helpers: fix deadlock caused by double read lock#11767BurtonQin wants to merge 1 commit into
BurtonQin wants to merge 1 commit into
Conversation
sorpaas
approved these changes
Jul 29, 2020
sorpaas
left a comment
Collaborator
There was a problem hiding this comment.
Nice! I remember we deliberately tried to keep lock as short as possible, but turned out in some situations they must be obtained in advance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #11766,
block_hash(), the twonumbers.read()may be interleaved bynumbers.write()from another thread.https://github.com/openethereum/openethereum/blob/f8cbdadfaaef30febbeab1ec5b7331a74ec7856a/ethcore/src/test_helpers/test_client.rs#L360
The fix is to use one
numbers.read()instead of two.chain_info(), the twodifficulty.read()(first_block.read(),ancient_block.read()) may be interleaved by their corresponding write lock from another thread.https://github.com/openethereum/openethereum/blob/f8cbdadfaaef30febbeab1ec5b7331a74ec7856a/ethcore/src/test_helpers/test_client.rs#L491-L502
I lift the read locks and order them as they are declared. Currently, no conflicting lock order is found.