Skip to content

chore(base-images): sync INDEX_URL from versions_config aipcc_wheel_index - #4332

Open
ide-developer wants to merge 2 commits into
mainfrom
jd_base_index_automation
Open

chore(base-images): sync INDEX_URL from versions_config aipcc_wheel_index#4332
ide-developer wants to merge 2 commits into
mainfrom
jd_base_index_automation

Conversation

@ide-developer

@ide-developer ide-developer commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add release.aipcc_wheel_index.{stream,use_test} to versions_config.yml / schema.
  • Extend make sync-build-args-from-versions to rewrite base-images/build-args/*.conf INDEX_URL via index_url_resolver helpers.
  • Seed to 3.5-EA2 / use_test: true (normalizes ROCm onto the shared test stream; content bump to 3.6-EA1 is a separate PR).

Fixes #4330

Companion

Direct INDEX_URL bump to 3.6-EA1-test: #4331 — prefer merging that first if base rebuilds are urgent.

Test plan

  • uv run pytest tests/test_versions_config_schema.py tests/unit/scripts/test_update_build_args_from_versions.py
  • After merge, mid-release index changes are edit versions_config.yml + make sync-build-args-from-versions only

@openshift-ci
openshift-ci Bot requested a review from daniellutz August 8, 2026 12:25
@github-actions github-actions Bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Aug 8, 2026
@openshift-ci
openshift-ci Bot requested a review from ysok August 8, 2026 12:25
@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@jiridanek, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a6f094b-cdd7-4829-805e-3e505f33830e

📥 Commits

Reviewing files that changed from the base of the PR and between 8baaf9f and ef1a7e0.

📒 Files selected for processing (8)
  • base-images/README.md
  • ci/versions_config.schema.json
  • ci/versions_config_schema.py
  • docs/base_image_versions_update_configuration.md
  • scripts/update_build_args_from_versions.py
  • tests/test_versions_config_schema.py
  • tests/unit/scripts/test_update_build_args_from_versions.py
  • versions_config.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/l label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Superseded by newer run: https://github.com/opendatahub-io/notebooks/actions/runs/31257217695

CI status [antigravity]

Run: Build Notebooks (push) #312572088333/3 complete · 3 skipped
Last updated: 2026-08-08T12:26:04Z

No workbench image jobs ran; all matrix jobs were skipped.

@openshift-ci openshift-ci Bot added size/l and removed size/l labels Aug 8, 2026
@ide-developer ide-developer linked an issue Aug 8, 2026 that may be closed by this pull request
@openshift-ci openshift-ci Bot added size/l and removed size/l labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Superseded by newer run: https://github.com/opendatahub-io/notebooks/actions/runs/31257460350

CI status [antigravity]

Run: Build Notebooks (pr) #312572176953/3 complete · 1 passed · 2 skipped
Last updated: 2026-08-08T12:26:43Z

No workbench image jobs ran; all matrix jobs were skipped.

@codecov-commenter

codecov-commenter commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.53%. Comparing base (8baaf9f) to head (ef1a7e0).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
scripts/update_build_args_from_versions.py 90.90% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4332      +/-   ##
==========================================
+ Coverage   44.12%   44.53%   +0.40%     
==========================================
  Files          45       45              
  Lines        5849     5899      +50     
  Branches      975      983       +8     
==========================================
+ Hits         2581     2627      +46     
- Misses       3049     3051       +2     
- Partials      219      221       +2     
Flag Coverage Δ
python 44.53% <92.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ci/versions_config_schema.py 92.04% <100.00%> (+0.58%) ⬆️
scripts/update_build_args_from_versions.py 72.38% <90.90%> (+0.91%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8baaf9f...ef1a7e0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📋 Review Summary

This pull request introduces valuable automation for synchronizing AIPCC wheel index INDEX_URL configurations in base images from versions_config.yml. The implementation is robustly covered by JSON schema definitions, Python updater logic, documentation updates, and unit tests. No issues or required changes were identified in the diff.

🔍 General Feedback

  • The separation of concerns between release metadata and the AIPCC wheel index stream (aipcc_wheel_index) is clean and well-documented.
  • Comprehensive unit tests successfully cover the new schema validations, expected configuration structures, and strict error handling for missing or malformed configuration values.

I did not post any inline review comments.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Superseded by newer run: https://github.com/opendatahub-io/notebooks/actions/runs/31257499999

CI status [antigravity]

Run: Build Notebooks (push) #312574603503/3 complete · 3 skipped
Last updated: 2026-08-08T12:32:29Z

No workbench image jobs ran; all matrix jobs were skipped.

jiridanek and others added 2 commits August 8, 2026 14:33
…ndex

Teach make sync-build-args-from-versions to rewrite base-images AIPCC
INDEX_URL confs from release.aipcc_wheel_index so release kickoff keeps
baked PIP_INDEX_URL aligned. Seed to 3.5-EA2-test (normalizes rocm).

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Superseded by newer run: https://github.com/opendatahub-io/notebooks/actions/runs/31257501675

CI status [antigravity]

Run: Build Notebooks (push) #312574999993/3 complete · 3 skipped
Last updated: 2026-08-08T12:33:30Z

No workbench image jobs ran; all matrix jobs were skipped.

@jiridanek

Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 52 minutes.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

CI status [antigravity]

Run: Build Notebooks (pr) #312575016753/3 complete · 1 passed · 2 skipped
Last updated: 2026-08-08T12:33:55Z

No workbench image jobs ran; all matrix jobs were skipped.

@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 8, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/l tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INDEX_URL base-images bump (PR 1) + release automation (PR 2)

3 participants